Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added a workflow for manual publishing of Worklets using OIDC. Previously we always released everything with 2FA on NPM, beside the nightly versions.
I tried to use the common publishing workflow on https://github.com/software-mansion/npm-package-publish but unfortunately it's not yet customizable enough for our case.
This workflow effectively duplicates the code from
npm-worklets-package-buildworkflow, but unfortunately the common logic couldn't be easily extracted to a separate action.I decided to add this action in this form to prevent delaying the releases even further. Temporary redundancy will be handled with a proper refactor in the near future.
NPM OIDC can only be registered on one workflow, so I moved its contents into a wrapper workflow
npm-worklets-publish.yml(I hope it works)Test plan
Test of CI: https://github.com/software-mansion/react-native-reanimated/actions/runs/23023763129