fix: pass make_latest to finalizeRelease #706
Closed
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR softprops#692 introduced draft-first release creation, but finalizeRelease does not pass make_latest when updating the release from draft to published. This causes releases to be marked as "latest" despite make_latest: false being set. When make_latest is omitted from the updateRelease call, GitHub's API defaults to determining "latest" based on semver comparison, ignoring the original make_latest setting. Fixes softprops#703
1 task
Collaborator
|
@EronWright can you show me how you tested the commit? Thanks! cc @dumbmoron |
Author
|
Sorry, I'm not able to work on this. Do feel free to close this PR if the fix is not correct. |
Contributor
|
I can definitely reproduce the bug, but for some reason I am still getting the newly made release set to latest even with |
Author
|
@dumbmoron sorry that I don't have any other insights. I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #692 introduced draft-first release creation, but
finalizeReleasedoes not passmake_latestwhen updating the release from draft to published. This causes releases to be marked as "latest" despitemake_latest: falsebeing set.Problem
When
make_latestis omitted from theupdateReleasecall infinalizeRelease, GitHub's API defaults to determining "latest" based on semver comparison, ignoring the originalmake_latestsetting.Fix
Pass
make_latestthrough thefinalizeReleasecall chain:Releaserinterface to acceptmake_latestparameterGitHubReleaser.finalizeReleaseto passmake_latestto the APIfinalizeReleasefunction to passconfig.input_make_latestFixes #703