Skip to content

feat: add support of node_redis 5#36

Open
AndrijVasyliev wants to merge 1 commit intosocketio:mainfrom
AndrijVasyliev:feature/add-support-on-node-redis-5
Open

feat: add support of node_redis 5#36
AndrijVasyliev wants to merge 1 commit intosocketio:mainfrom
AndrijVasyliev:feature/add-support-on-node-redis-5

Conversation

@AndrijVasyliev
Copy link

No description provided.

@tj-mc
Copy link

tj-mc commented Jul 28, 2025

Legendary

@AndrijVasyliev
Copy link
Author

AndrijVasyliev commented Aug 20, 2025

Probably I miss something, that I must accomplish for this PR be merged?
I will be most gratefull if someone points at those things.

@june07
Copy link

june07 commented Oct 13, 2025

yea, this seems to work perfectly. Be nice if the maintainer would merge this or otherwise provide some direction. TIA

@darrachequesne
Copy link
Member

Hi, sorry for the delay.

Unfortunately, I don't think this works with a Redis cluster, as we need isolated pools (commandOptions({ isolated: true }) in v4, client.createPool() in v5), so that client.xread() does not block client.xadd() operations.

References:

Possibly related: redis/node-redis#2928

@SupertigerDev
Copy link

Is it something that node-redis 5 lacks or is it missing from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants