chore: render all locations in UFM SARIF output#539
Draft
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
j-luong
commented
Feb 4, 2026
| {{- if $locations }}, | ||
| "locations": [ | ||
| {{- if $location }} | ||
| {{- $locationsSize := sub (len $locations) 1 }} |
Contributor
Author
There was a problem hiding this comment.
ensuring no trailing comma on last item. using the same pattern for tags array
j-luong
commented
Feb 4, 2026
| { | ||
| "fullyQualifiedName": {{ getQuotedString (index $logLoc "fullyQualifiedName") }} | ||
| } | ||
| }{{if lt $logLocIndex $logicalLocsSize}},{{end}} |
Contributor
Author
There was a problem hiding this comment.
ensures no trailing comma on last item
j-luong
commented
Feb 4, 2026
Comment on lines
+66
to
+69
| {{- $location := "" }} | ||
| {{- $physicalLoc := "" }} | ||
| {{- $region := "" }} | ||
| {{- $artifactLocation := "" }} |
Contributor
Author
There was a problem hiding this comment.
add default values to avoid potential panics
j-luong
commented
Feb 4, 2026
Comment on lines
+139
to
+150
| {{- if $artifactLocation }} | ||
| "artifactLocation": { | ||
| "uri": {{ getQuotedString (index $artifactLocation "uri") }} | ||
| }, | ||
| {{- end }} | ||
| "replacements": [ | ||
| { | ||
| {{- if $region }} | ||
| "deletedRegion": { | ||
| "startLine": {{ index $region "startLine" }} | ||
| }, | ||
| {{- end }} |
Contributor
Author
There was a problem hiding this comment.
we depended on values from the 1st item in locations array here, not sure if this needs updating too
j-luong
commented
Feb 4, 2026
| findings := issue.GetFindings() | ||
| if len(findings) == 0 { | ||
| // GetElementAtIndex returns an item from a slice at the given index | ||
| func GetElementAtIndex(slice []map[string]any, index int) map[string]any { |
Contributor
Author
There was a problem hiding this comment.
introduced to maintain behaviour for "artifactChanges" SARIF property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.