chore: Remove account parameter #4172
Conversation
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Integration tests failure for 0155e4589ffc92d3074627bea499ae2281e2cb71 |
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Account-level tests failure for 6173e537d75acf357051d555eb6bcbe407ad3d45 |
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Integration tests cancelled for 6173e537d75acf357051d555eb6bcbe407ad3d45 |
|
Account-level tests failure for 4b65711862481f31b26c9bc3820ea8edf62b4a87 |
|
Integration tests success for 4b65711862481f31b26c9bc3820ea8edf62b4a87 |
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Account-level tests failure for a946d22f7b9fb30848391929065498a7851bbe45 |
|
Integration tests failure for a946d22f7b9fb30848391929065498a7851bbe45 |
sfc-gh-jcieslak
force-pushed
the
remove-account-parameter
branch
from
a946d22 to
cf9ae69
Compare
|
Integration tests cancelled for cf9ae69266289271b8ce7f5fbdb046b5a97d42b7 |
MIGRATION_GUIDE.md
Outdated
|
|
||
| ### *(breaking change)* The removal of `SAML_IDENTITY_PROVIDER` from `snowflake_current_account` and `snowflake_current_organization_account` resources | ||
|
|
||
| Due to changes on the Snowflake side, the `SAML_IDENTITY_PROVIDER` parameter is now deprecated (see [Snowflake documentation](https://docs.snowflake.com/en/sql-reference/parameters#saml-identity-provider)). |
There was a problem hiding this comment.
Let's emphasize that:
- not only it is deprecated, but it can't be used in SF (it fails with an error),
- the affected resources are in preview, so we don't need to bump the major version.
| }) | ||
| } | ||
|
|
||
| func TestAcc_CurrentAccount_migrateFromV2_10_0(t *testing.T) { |
There was a problem hiding this comment.
Nit: v2_10_2, for the other test as well.
There was a problem hiding this comment.
My mistake, but didn't change due to cumbersome test setup (I know this works, thus 2_10_2 should work, but didn't want to change and validate it locally as it takes some time to set up). I would say, let's leave it like this, as it validates what it supposed to.
|
Account-level tests success for 5b009c4865af92832694ed2d59e240a70fa33f70 |
|
Integration tests success for 5b009c4865af92832694ed2d59e240a70fa33f70 |
# Conflicts: # MIGRATION_GUIDE.md
|
Integration tests cancelled for 46c6970f78b7cd8c658403c4b9c44ab37724906c |
|
Integration tests success for 627538b8c17e1e82a074ead431e5cacba0173a30 |
# Conflicts: # MIGRATION_GUIDE.md
|
Integration tests success for 31a8969ecf92e287f83716ee858291509d08be8f |
Related to #4010, removing deprecated account parameter
The
snowflake_account_parameterwas not adjusted as removed parameter wasn't previously listed as valid parameter there anyway.Note: tested with and without state upgrader that would explicitly remove the field with
deletefunction in Go, but that didn't seem to change anything (both versions were passing the test)