test: add additional wire challenge test cases#2661
Open
SimonThormeyer wants to merge 15 commits intosmallstep:masterfrom
Open
test: add additional wire challenge test cases#2661SimonThormeyer wants to merge 15 commits intosmallstep:masterfrom
SimonThormeyer wants to merge 15 commits intosmallstep:masterfrom
Conversation
… and finalizing response This allows adding an integration test without duplicating the entire flow.
|
|
github-actions
Bot
added
the
needs triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
This is intended to add additional test cases for the wire challenges, mainly by just copy-and-pasting existing test cases and tweaking them in the right places. It doesn't touch any code outside of the specific wire tests.
In our downstream usage, we were previously maintaining similar test cases, however, it greatly reduces complexity for us to directly test these cases here.
Please also refer to the commit sequence to see what is being tested.
Would you be open to review/merge this?