fix: enforce termsOfServiceAgreed when termsOfService is configured#2654
Open
avasis-ai wants to merge 1 commit into
Open
fix: enforce termsOfServiceAgreed when termsOfService is configured#2654avasis-ai wants to merge 1 commit into
avasis-ai wants to merge 1 commit into
Conversation
Per RFC 8555 §7.3.3, when an ACME provisioner has termsOfService configured, the server should reject newAccount requests that do not set termsOfServiceAgreed to true, returning a userActionRequired error. Closes smallstep#2539
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per RFC 8555 §7.3.3, when an ACME provisioner has
termsOfServiceconfigured, the server should rejectnewAccountrequests that do not settermsOfServiceAgreedtotrue.Previously, the server advertised
termsOfServicein the directory metadata but did not enforce that clients agree to it before creating an account.Changes
NewAccounthandler (acme/api/account.go) that returns anErrorUserActionRequiredTypeACME error whentermsOfServiceis configured on the provisioner but the request does not includetermsOfServiceAgreed: true.Testing
The fix follows the existing error handling pattern used for other ACME validation checks (e.g.,
onlyReturnExisting). TheacmeProvisionerFromContextreturns*provisioner.ACMEwhich exposes theTermsOfServicefield, consistent with how it's accessed inhandler.gofor directory metadata.Closes #2539