Push the policy time forward again.#193
Merged
TomHennen merged 1 commit intoslsa-framework:mainfrom Jun 5, 2025
Merged
Conversation
There's an issue where we don't look at all the available provenance just the first one we find. So even though prior commits have 'good' provenance that would meet this policy they also have 'bad' provenance that doesn't. That bad provenance is found 'first' which means we fail the policy check. We could fix that, but it's tricky. Better to get things working again and we can resolve later. Signed-off-by: Tom Hennen <[email protected]>
Contributor
Author
|
At least that was my theory. @puerco has noted that there seems to only be one provenance attestation. Some deeper analysis will be needed. Still better to get things working again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an issue where we don't look at all the available provenance just the first one we find. So even though prior commits have 'good' provenance that would meet this policy they also have 'bad' provenance that doesn't. That bad provenance is found 'first' which means we fail the policy check. We could fix that, but it's tricky. Better to get things working again and we can resolve later.