Fix file path when fetching notes#184
Merged
TomHennen merged 3 commits intoslsa-framework:mainfrom Jun 5, 2025
Merged
Conversation
This commit fixes the path we request from github to retrieve a commit's notes. Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
This commit adds a unit test for the GetNotesForCommit func that connects to the github api. It will be skipped if no token is set in the environment. Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the path we request from GitHub to retrieve a commit's notes.
I've added a unit test to make sure we are getting the expected data from GitHub that can be run locally with a token in the environment or skipped when there is not (ie in CI).
It also fixes a small bug where tokens from the environment were dropped at the gh connector init.
Signed-off-by: Adolfo Garcia Veytia (puerco) [email protected]