Open
Conversation
Member
|
Thanks!
…On Tue, Oct 22, 2019, 1:34 PM Merill ***@***.***> wrote:
@supermerill <https://github.com/supermerill> requested your review on:
#4876 <#4876> some more tests as a
code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4876?email_source=notifications&email_token=AAAHYCS3Z5ZNY5GHWVTMKC3QP5BS7A5CNFSM4JDTVBG2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUL5T7UA#event-2734374864>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHYCRWXBIUMQYROMVNIBLQP5BS7ANCNFSM4JDTVBGQ>
.
|
|
✅ Build Slic3r 1.3.0-master-2369 completed (commit a1844fcd04 by @) |
Member
|
@supermerill I'm seeing some failures in the build output, was that expected? |
|
|
||
| // Generate one specific random path set and save it for later comparison | ||
| ExtrusionPaths nosort_path_set {random_paths()}; | ||
| ExtrusionPaths nosort_path_set{ random_paths() }; |
Member
There was a problem hiding this comment.
Was this the result of an automatic code formatter?
| print->make_brim(); | ||
| THEN("Brim Extrusion collection has 12 loops in it") { | ||
| REQUIRE(print->brim.items_count() == 12); | ||
| double nbLoops = 6.0 / print->brim_flow().spacing(); |
Member
There was a problem hiding this comment.
Why the change here for the extrusion collection?
Collaborator
Author
There was a problem hiding this comment.
I made it that way because I wanted it to check if it makes the correct number of loop and not checking if the spacing is exactly what we tough about it (the layer heigh isn't set, btw)
I should had changes other tests also, i think that only this one bother me at the time because it is so large, a little difference in spacing can change the loop count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I have written some tests that could make their way here.
I didn't had the time to test them since this merge, but i will do when possible.