fix(dashboard): use cluster_name_on_cloud for instance link filters

[LikiosSedo]

Summary

Instance links in the managed jobs dashboard point to wrong VM names in the cloud console.

Root Cause

generate_instance_links() receives self.cluster_name (generated with add_user_hash=False), but cloud instances are tagged with cluster_name_on_cloud (which includes the user hash suffix). The URL filter therefore matches nothing.

For example:

• self.cluster_name = sky-job-abc
• handle.cluster_name_on_cloud = sky-job-abc-user123
• GCP/AWS instances are tagged with ray-cluster-name: sky-job-abc-user123
• The generated console URL filters for ray-cluster-name: sky-job-abc → no results

Fix

Use handle.cluster_name_on_cloud instead of self.cluster_name when calling generate_instance_links() in sky/jobs/recovery_strategy.py.

Fixes #9047

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the managed jobs dashboard where instance links failed to correctly identify virtual machines in cloud consoles. The fix involves updating the cluster name used for generating these links to ensure accurate filtering and display of cloud instances.

Highlights

• Instance Link Fix: Resolved an issue where instance links in the managed jobs dashboard were incorrect because they used self.cluster_name instead of handle.cluster_name_on_cloud, leading to mismatched VM names in cloud console filters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the _launch method in sky/jobs/recovery_strategy.py to use handle.cluster_name_on_cloud instead of self.cluster_name when generating instance links. This change likely ensures that the correct cluster name is used for linking purposes. I have no feedback to provide.