Skip to content

[Dashboard] Extend plugin data provider API#9149

Open
lloyd-brown wants to merge 2 commits intomasterfrom
lloyd/auth-integration
Open

[Dashboard] Extend plugin data provider API#9149
lloyd-brown wants to merge 2 commits intomasterfrom
lloyd/auth-integration

Conversation

@lloyd-brown
Copy link
Collaborator

Summary

  • Extend registerDataProvider to support passing hooks and components in addition to useHook, enabling plugins to share multiple hooks and UI components through the data provider registry
  • Add a PluginSlot to the recipe detail page actions area (recipes.detail.actions) so plugins can inject custom action buttons

Test plan

  • Verify existing data providers still work (backward compatible — useHook still works)
  • Verify new hooks/components fields are accessible via getDataProvider()
  • Verify PluginSlot renders in recipe detail page action bar

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Agent (recipe-devspace) and others added 2 commits March 20, 2026 14:54
…ponents

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the dashboard's plugin architecture by expanding the data provider API to allow plugins to expose a wider range of functionality, including multiple hooks and UI components. Additionally, it introduces a new extensibility point on the recipe detail page, enabling plugins to seamlessly integrate custom actions into the user interface.

Highlights

  • Extended Data Provider API: The registerDataProvider function now supports passing hooks and components in addition to useHook, allowing plugins to share multiple hooks and UI components.
  • New Plugin Slot: A PluginSlot named recipes.detail.actions has been added to the recipe detail page, enabling plugins to inject custom action buttons.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lloyd-brown lloyd-brown requested a review from kevinzwang March 20, 2026 23:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends the plugin data provider API to support sharing hooks and components, and adds a new plugin slot on the recipe detail page for custom actions. The changes are well-implemented and align with the goals described. I've added one suggestion to improve the robustness of the data provider registration by adding type checks to prevent potential runtime errors from misconfigured plugins.

Comment on lines +747 to +748
hooks: config.hooks || {},
components: config.components || {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved robustness, it's advisable to ensure that config.hooks and config.components are objects before they are assigned. The current || {} operator could allow other truthy, non-object values (like strings or numbers) to be assigned if a plugin is misconfigured. This could lead to runtime errors in other parts of the application that consume these values, for example in usePluginComponents. A more defensive check would prevent such issues.

Suggested change
hooks: config.hooks || {},
components: config.components || {},
hooks: (config.hooks && typeof config.hooks === 'object') ? config.hooks : {},
components: (config.components && typeof config.components === 'object') ? config.components : {},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants