Merged
Conversation
fgiorgetti
reviewed
Oct 20, 2025
| slog.Any("error", err)) | ||
| return err | ||
| } else { | ||
| updated := false |
Member
There was a problem hiding this comment.
@ajssmith I believe we need a similar validation here for listeners defined with exposePodsByName=true.
nluaces
reviewed
Nov 3, 2025
| @@ -866,11 +866,10 @@ func (s *Site) CheckConnector(name string, connector *skupperv2alpha1.Connector) | |||
|
|
|||
| func (s *Site) updateListenerStatus(listener *skupperv2alpha1.Listener, err error) error { | |||
Member
There was a problem hiding this comment.
Not a blocker: should be this method called something like updateListenerErrorStatus, given that it is only used in error cases?
Member
Author
There was a problem hiding this comment.
Might lean towards treating in a separate issue. There is a need to look at indicating errors back more generally.
nluaces
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the listener resource from overwriting a pre-existing service. Also, remove log message that would be continuously generated sans configuration change.