refactor: replace chrismellard/docker-credential-acr-env with inline ACR auth#686
Draft
refactor: replace chrismellard/docker-credential-acr-env with inline ACR auth#686
Conversation
…ACR auth Replace the external dependency with an inline implementation that directly uses go-autorest/adal (already in the module graph) and a simple HTTP POST to the registry's /oauth2/exchange endpoint. This removes both chrismellard/docker-credential-acr-env and the heavy Azure/azure-sdk-for-go transitive dependency.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The client credentials path was using cc.Resource (from AZURE_AD_RESOURCE env var) instead of the resource parameter passed to the function, creating an inconsistency with the federated and MSI paths. Use the resource parameter uniformly across all three auth methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chrismellard/docker-credential-acr-env(and its heavy transitive dependencyAzure/azure-sdk-for-go) was used inpkg/image/auth.goto provide Azure Container Registry credentials. Replaces it with an inline implementation usinggo-autorest/adal, which is already in the module graph.The inline implementation supports the same 3 auth methods as the original: client credentials, federated OIDC JWT, and MSI (managed service identity).
Changes
pkg/image/acr.go: inline ACR credential helper with client credentials, federated token, and MSI supportpkg/image/auth.go: removedchrismellardimport, callsnewACRCredentialsHelper()from new filego.mod/go.sum:chrismellard/docker-credential-acr-envandAzure/azure-sdk-for-goremoved;go-autorest/adalandgo-autorest/autorest/azure/authpromoted from indirect to directdocs/pages/licenses/devpod.mdx: removedchrismellardentry