refactor: replace tidwall/jsonc with tailscale/hujson#679
Draft
refactor: replace tidwall/jsonc with tailscale/hujson#679
Conversation
Both packages strip JSON comments and trailing commas (JSONC format). hujson was already an indirect dep in the module tree; promote it to a direct dep and remove tidwall/jsonc entirely. hujson.Standardize() returns an error on malformed input, which is now propagated rather than silently ignored as before.
Remove stale github.com/tidwall/jsonc entry and add github.com/tailscale/hujson (BSD-3-Clause) which replaced it.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tidwall/jsoncwas used inpkg/devcontainer/config/parse.goto strip comments and trailing commas from devcontainer JSON files before unmarshalling. Replaces it withtailscale/hujson, which was already an indirect dependency and provides stricter, AST-based JSONC parsing.The replacement adds proper error propagation:
hujson.Standardize()returns an error on genuinely malformed input, whereastidwall/jsoncsilently passed malformed files through tojson.Unmarshal. For all valid devcontainer.json files there is no behavior change.Changes
pkg/devcontainer/config/parse.go: replacedjsonc.ToJSON(data)pattern withhujson.Standardize(data)(2 call sites), with error propagationgo.mod:tidwall/jsoncremoved;tailscale/hujsonpromoted from indirect to directdocs/pages/licenses/devpod.mdx: removedtidwall/jsoncentry, addedtailscale/hujson(BSD-3-Clause)