fix(driver/custom): pass provider name to ToEnvironment#675
Open
skevetter wants to merge 4 commits intoprovider-namefrom
Open
fix(driver/custom): pass provider name to ToEnvironment#675skevetter wants to merge 4 commits intoprovider-namefrom
skevetter wants to merge 4 commits intoprovider-namefrom
Conversation
The backward-compat fallback for legacy DEVPOD_<FLAG> env vars would compute DEVPOD_DEVPOD_HOME for the devpod-home flag, since the prefix guard already resolves it to DEVPOD_HOME. Skip the fallback when the flag name already starts with the env prefix.
The PR added a providerName parameter to ToEnvironment to set DEVPOD_PROVIDER in the provider's environment, but the custom driver call site passed an empty string. Use workspace.Workspace.Provider.Name so custom driver commands also receive the provider name.
This reverts commit a201a0d.
The custom driver call site passes an empty string for providerName, so DEVPOD_PROVIDER is never set in the environment for custom driver commands. Use workspace.Workspace.Provider.Name to match the behavior of other call sites. Depends on #615
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToEnvironWithBinariespasses an empty string forproviderNametoToEnvironment, soDEVPOD_PROVIDERis never set in the environment for custom driver commandsworkspace.Workspace.Provider.Nameto match all other call sitesContext
Found during review of #615. All other
ToEnvironmentcall sites (viaToEnvironmentWithBinariesindownload.go) correctly passopts.Config.Name, but the agent-side custom driver was missed.