[python] Merge the somacore library directly into the tiledbsom python library#4403
Draft
[python] Merge the somacore library directly into the tiledbsom python library#4403
somacore library directly into the tiledbsom python library#4403Conversation
jp-dark
force-pushed
the
dark/remove-somacore
branch
from
891f59f to
d3727f1
Compare
Updating to `typeguard==4.4.4` causes it to fail when using the `|` syntax in a TypedDict definition.
jp-dark
force-pushed
the
dark/remove-somacore
branch
from
d3727f1 to
3aea669
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
+ Coverage 86.15% 88.94% +2.78%
==========================================
Files 140 68 -72
Lines 21210 7722 -13488
Branches 13 0 -13
==========================================
- Hits 18274 6868 -11406
+ Misses 2936 854 -2082
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Closes SOMA-822
Changes:
This PR moves the
somacorelibrary directly into TileDB-SOMA and removes duplicate code between the two libraries where possible.