Add no-for-loop-extra-variable rule for cached array-length loops#2919
Open
juarezsousa-ctrl wants to merge 6 commits intosindresorhus:mainfrom
Open
Add no-for-loop-extra-variable rule for cached array-length loops#2919juarezsousa-ctrl wants to merge 6 commits intosindresorhus:mainfrom
no-for-loop-extra-variable rule for cached array-length loops#2919juarezsousa-ctrl wants to merge 6 commits intosindresorhus:mainfrom
Conversation
9cc676b to
89d4146
Compare
Author
|
Rebased on latest All checks are passing now. |
814b622 to
0e023e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295
This adds a new
unicorn/no-for-loop-extra-variablerule to handle the specific cached array-lengthforloop shape discussed in #295.Context:
no-for-loop#295 identified thatno-for-loopdoes not report on loops likefor (let i = 0, j = array.length; i < j; i += 1).no-for-loop-extra-variablerule #492 explored a separate rule for this, but it grew into a broader implementation and was never finished.This PR takes a narrower approach:
i = 0, j = array.lengthpatternno-for-loopitself is left unchanged in this PR.Included:
no-for-loop-extra-variablerule