fix(webflow): fix collection & site dropdown in webflow triggers #2849
+433
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR converts Webflow trigger site and collection inputs from manual text fields to dynamic dropdowns, improving UX by fetching available options from the Webflow API. Key Changes:
Critical Issue:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Trigger UI
participant SubBlockStore
participant API Routes
participant Webflow API
User->>Trigger UI: Select Webflow credential
Trigger UI->>SubBlockStore: Store credential ID
User->>Trigger UI: Open site dropdown
Trigger UI->>SubBlockStore: getValue(blockId, 'triggerCredentials')
SubBlockStore-->>Trigger UI: credential ID
Trigger UI->>API Routes: POST /api/tools/webflow/sites
API Routes->>Webflow API: GET /v2/sites
Webflow API-->>API Routes: sites array
API Routes-->>Trigger UI: formatted sites
Trigger UI-->>User: Display site options
User->>Trigger UI: Select site
Trigger UI->>SubBlockStore: Store site ID
User->>Trigger UI: Open collection dropdown
Trigger UI->>SubBlockStore: getValue(blockId, 'triggerCredentials')
SubBlockStore-->>Trigger UI: credential ID
Trigger UI->>SubBlockStore: getValue(blockId, 'siteId')
SubBlockStore-->>Trigger UI: site ID
Trigger UI->>API Routes: POST /api/tools/webflow/collections
API Routes->>Webflow API: GET /v2/sites/{siteId}/collections
Webflow API-->>API Routes: collections array
API Routes-->>Trigger UI: formatted collections
Trigger UI-->>User: Display collection options
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_changed', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition in apps/sim/blocks/types.ts:302-305.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_changed.ts
Line: 45:45
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition in `apps/sim/blocks/types.ts:302-305`.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_changed', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_changed.ts
Line: 111:111
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_created', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_created.ts
Line: 58:58
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_created', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_created.ts
Line: 124:124
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_deleted', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_deleted.ts
Line: 45:45
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| field: 'selectedTriggerId', | ||
| value: 'webflow_collection_item_deleted', | ||
| }, | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/collection_item_deleted.ts
Line: 111:111
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.| required: true, | ||
| options: [], | ||
| mode: 'trigger', | ||
| fetchOptions: async (blockId: string) => { |
Contributor
There was a problem hiding this comment.
syntax: fetchOptions signature is missing the required subBlockId parameter. Should be async (blockId: string, subBlockId: string) to match the SubBlockConfig type definition.
Suggested change
| fetchOptions: async (blockId: string) => { | |
| fetchOptions: async (blockId: string, subBlockId: string) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/triggers/webflow/form_submission.ts
Line: 37:37
Comment:
**syntax:** `fetchOptions` signature is missing the required `subBlockId` parameter. Should be `async (blockId: string, subBlockId: string)` to match the `SubBlockConfig` type definition.
```suggestion
fetchOptions: async (blockId: string, subBlockId: string) => {
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist