Skip to content

Add RFC3339 time to points#54

Open
jsnapoli1 wants to merge 5 commits intosimpleiot:mainfrom
jsnapoli1:feature-point-timestamps
Open

Add RFC3339 time to points#54
jsnapoli1 wants to merge 5 commits intosimpleiot:mainfrom
jsnapoli1:feature-point-timestamps

Conversation

@jsnapoli1
Copy link
Copy Markdown

No description provided.

@cbrake
Copy link
Copy Markdown
Member

cbrake commented Jan 13, 2026

Does siot_test_native work for you? I'm just getting set up to test these, so might be missing something.

-- west build: building application
[1/1090] Preparing syscall dependency handling

[229/1090] Building C object modules/picolibc/CMakeFiles/c.dir/newlib/libc/stdlib/arc4random.c.obj
In file included from /scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/stdlib/arc4random.c:38:
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/stdlib/chacha_private.h:68:31: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (17 chars into 16 available) [-Wunterminated-string-initialization]
   68 | static const char sigma[16] = "expand 32-byte k";
      |                               ^~~~~~~~~~~~~~~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/stdlib/chacha_private.h:69:29: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (17 chars into 16 available) [-Wunterminated-string-initialization]
   69 | static const char tau[16] = "expand 16-byte k";
      |                             ^~~~~~~~~~~~~~~~~~
[414/1090] Building C object modules/picolibc/CMakeFiles/c.dir/newlib/libc/time/asctime_r.c.obj
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c: In function ‘asctime_r’:
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:9: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |         ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:16: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:23: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                       ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:30: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                              ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:37: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                                     ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:44: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                                            ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:34:51: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   34 |         "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
      |                                                   ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:9: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |         ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:16: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |                ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:23: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |                       ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:30: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |                              ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:37: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |                                     ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:37:44: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   37 |         "Jan", "Feb", "Mar", "Apr", "May", "Jun",
      |                                            ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:9: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |         ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:16: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |                ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:23: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |                       ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:30: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |                              ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:37: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |                                     ^~~~~
/scratch/simpleiot/zephyr-siot/modules/lib/picolibc/newlib/libc/time/asctime_r.c:38:44: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Wunterminated-string-initialization]
   38 |         "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
      |                                            ^~~~~
[950/1090] Generating include/generated/zephyr/version.h
-- Zephyr version: 4.1.0 (/scratch/simpleiot/zephyr-siot/zephyr), build: v4.1.0-9-g5556efb66c55
[1032/1090] Building C object modules/siot/lib/CMakeFiles/..__siot__lib.dir/zbus.c.obj
FAILED: [code=1] modules/siot/lib/CMakeFiles/..__siot__lib.dir/zbus.c.obj
/usr/bin/gcc -DKERNEL -DK_HEAP_MEM_POOL_SIZE=3072 -D__LINUX_ERRNO_EXTENSIONS__ -D__ZEPHYR__=1 -I/scratch/simpleiot/zephyr-siot/siot/build/zephyr/include/generated/zephyr -I/scratch/simpleiot/zephyr-siot/zephyr/include -I/scratch/simpleiot/zephyr-siot/siot/build/zephyr/include/generated -I/scratch/simpleiot/zephyr-siot/zephyr/soc/native/inf_clock -I/scratch/simpleiot/zephyr-siot/zephyr/boards/native/native_sim -I/scratch/simpleiot/zephyr-siot/zephyr/scripts/native_simulator/common/src/include -I/scratch/simpleiot/zephyr-siot/zephyr/scripts/native_simulator/native/src/include -I/scratch/simpleiot/zephyr-siot/zephyr/subsys/testsuite/include -I/scratch/simpleiot/zephyr-siot/zephyr/subsys/testsuite/coverage -I/scratch/simpleiot/zephyr-siot/zephyr/subsys/testsuite/ztest/include -I/scratch/simpleiot/zephyr-siot/siot/include -isystem /scratch/simpleiot/zephyr-siot/zephyr/lib/libc/common/include -isystem /scratch/simpleiot/zephyr-siot/siot/build/modules/picolibc/picolibc/include -fno-strict-aliasing -Os -imacros /scratch/simpleiot/zephyr-siot/siot/build/zephyr/include/generated/zephyr/autoconf.h -fno-common -g -gdwarf-4 -fdiagnostics-color=always -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/scratch/simpleiot/zephyr-siot/siot/tests=CMAKE_SOURCE_DIR -fmacro-prefix-map=/scratch/simpleiot/zephyr-siot/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/scratch/simpleiot/zephyr-siot=WEST_TOPDIR -ffunction-sections -fdata-sections -m32 -msse2 -mfpmath=sse -fvisibility=hidden -nostdinc -isystem /usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include -include /scratch/simpleiot/zephyr-siot/zephyr/arch/posix/include/undef_system_defines.h -ffreestanding -fno-builtin -std=c11 -MD -MT modules/siot/lib/CMakeFiles/..__siot__lib.dir/zbus.c.obj -MF modules/siot/lib/CMakeFiles/..__siot__lib.dir/zbus.c.obj.d -o modules/siot/lib/CMakeFiles/..__siot__lib.dir/zbus.c.obj -c /scratch/simpleiot/zephyr-siot/siot/lib/zbus.c
/scratch/simpleiot/zephyr-siot/siot/lib/zbus.c:5:10: fatal error: app_version.h: No such file or directory
    5 | #include "app_version.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
[1041/1090] Building C object modules/siot/lib/CMakeFiles/..__siot__lib.dir/point.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /scratch/simpleiot/zephyr-siot/siot/build

@cbrake
Copy link
Copy Markdown
Member

cbrake commented Jan 13, 2026

Looks like the app_version.h is a bug in main, fixing now ...

@cbrake
Copy link
Copy Markdown
Member

cbrake commented Jan 14, 2026

I fixed the issues in main and switched tests to run from the CI container #56

Please merge main.

I'm curious if the container works OK with your macos workflow?

Now getting another compile issue:

Generating files from /workdir/siot/build/zephyr/zephyr.elf for board: native_sim
[1114/1115] Building native simulator runner, and linking final executable
FAILED: zephyr/CMakeFiles/native_runner_executable zephyr/zephyr.exe /workdir/siot/build/zephyr/CMakeFiles/native_runner_executable /workdir/siot/build/zephyr/zephyr.exe
cd /workdir/siot/build/zephyr && /usr/bin/make -f /workdir/zephyr/scripts/native_simulator/Makefile all --warn-undefined-variables -r NSI_CONFIG_FILE=/workdir/siot/build/zephyr/NSI/nsi_config
/usr/bin/ld: /workdir/siot/build/zephyr/NSI/workdir/siot/build/zephyr/zephyr.elf.loc_cpusw.o: in function `point_dump':
/workdir/siot/lib/point.c:157:(.text.point_dump+0x108): undefined reference to `timeconv_rfc3339_from_epoch_ns_utc'
/usr/bin/ld: /workdir/siot/build/zephyr/NSI/workdir/siot/build/zephyr/zephyr.elf.loc_cpusw.o: in function `point_to_point_js':
/workdir/siot/lib/point.c:300:(.text.point_to_point_js+0x2d): undefined reference to `timeconv_rfc3339_from_epoch_ns_utc'
/usr/bin/ld: /workdir/siot/build/zephyr/NSI/workdir/siot/build/zephyr/zephyr.elf.loc_cpusw.o: in function `point_js_to_point':
/workdir/siot/lib/point.c:367:(.text.point_js_to_point+0x8d): undefined reference to `timeconv_epoch_ns_from_rfc3339'
collect2: error: ld returned 1 exit status
make: *** [/workdir/zephyr/scripts/native_simulator/Makefile:142: /workdir/siot/build/zephyr/zephyr.exe] Error 1
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /workdir/siot/build

It looks like that function is still in the app code:

rg timeconv_epoch_ns_from_rfc3339
lib/point.c
289:			timeconv_epoch_ns_from_rfc3339(time_buffer, sizeof(time_buffer));

apps/z-mr/src/timing.c
408:	uint64_t epoch_ns = timeconv_epoch_ns_from_rfc3339(rfc3339_str, strlen(rfc3339_str));

lib/timeconv.c
31:uint64_t timeconv_epoch_ns_from_rfc3339(const char *buf, size_t buf_len)
34:		LOG_DBG("timeconv_epoch_ns_from_rfc3339: null/empty input");
46:		LOG_DBG("timeconv_epoch_ns_from_rfc3339: string too short: '%s'", tmp);

include/timeconv.h
15:uint64_t timeconv_epoch_ns_from_rfc3339(const char *buf, size_t buf_len);

Really need CI with this repo -- will be working on that next ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants