[Feature] Introduce sender-blacklists (on both global/admin and user level)#2694
Open
chrisblech wants to merge 17 commits intosimple-login:masterfrom
Open
[Feature] Introduce sender-blacklists (on both global/admin and user level)#2694chrisblech wants to merge 17 commits intosimple-login:masterfrom
chrisblech wants to merge 17 commits intosimple-login:masterfrom
Conversation
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
acasajus
reviewed
Mar 25, 2026
Collaborator
|
Please move the management of the ForbiddenEnvelopeSender into a separate file that can be tested and called from other places instead of adding more code to the settings page. |
Collaborator
|
Also there are no tests for per-user entry, regex validation on entry or deletion. |
acasajus
reviewed
Mar 25, 2026
…fixes Feature/user blacklists review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using a self-hosted instance für some months now with a throughput of more than 5000 mails/month and consequently manually disabling spam-sender (on contact level), simplelogin blocks about 600 SPAM mails per month.
When looking at the remaining 350 spam mails that are still forwarded to my inbox (and get caught by GMails SPAM sensor), I realize that a significant amount of them belongs to "spammer-domains" or at least follow the same pattern.
This PR adds two levels of sender blacklists to SimpleLogin: Admin and Users can use this to block sender addresses (or whole domains / TLDs) by regex pattern.
global_sender_blacklist(pattern regex + enabled + comment)Migration and tests are included.
[Bonus/Example] My personal blacklist patterns:
@novastek\.homes$@devalser\.hair$@tabot\.com\.tr$@casang\.vip$^[a-z]+[0-9]{5}@[a-z]+\.[a-z]+\.shop$@juntadeandalucia\.es$@resend\.dev$