add assignment operator to int_vector_buffer iterator#364
Open
niklasb wants to merge 3 commits intosimongog:masterfrom
Open
add assignment operator to int_vector_buffer iterator#364niklasb wants to merge 3 commits intosimongog:masterfrom
niklasb wants to merge 3 commits intosimongog:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Contributor
Author
|
Somehow this iterator implementation is broken and we don't know why. We spent 2 hours now debugging it to no avail. The |
simongog
reviewed
May 2, 2017
| return it += i; | ||
| } | ||
|
|
||
| iterator& operator-(difference_type i) const |
Owner
There was a problem hiding this comment.
Isn't it enough to just remove the reference here?
Contributor
Author
There was a problem hiding this comment.
That's enough to fix the bug, yes. This pull request is primarily about about adding an assignment operator though.
niklasb
commented
May 15, 2017
Contributor
Author
niklasb
left a comment
niklasb
left a comment
There was a problem hiding this comment.
Any progress on this?
| return it += i; | ||
| } | ||
|
|
||
| iterator& operator-(difference_type i) const |
Contributor
Author
There was a problem hiding this comment.
That's enough to fix the bug, yes. This pull request is primarily about about adding an assignment operator though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it cannot be used in sd_vector constructor, probably amongst others.