Skip to content

Correct height calculation in the sections #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MVilaH wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Correct height calculation in the sections #1105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
848fed8
recalculating section dimensions for rowSpan
MVilaH Jan 15, 2026
bc810f6
Update
MVilaH Jan 18, 2026
c77b92c
Update
MVilaH Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,27 @@ export class Table {
}

getHeadHeight(columns: Column[]) {
return this.head.reduce(
(acc, row) => acc + row.getMaxCellHeight(columns),
0,
)
var rowSpan = 1
return this.head.reduce((acc, row) => {
if(rowSpan === 1){
rowSpan = row.getMaxRowSpan(columns)
return acc + row.getMaxCellHeight(columns)
}
rowSpan--
return acc
}, 0)
}

getFootHeight(columns: Column[]) {
return this.foot.reduce(
(acc, row) => acc + row.getMaxCellHeight(columns),
0,
)
var rowSpan = 1
return this.foot.reduce((acc, row) => {
if(rowSpan === 1){
rowSpan = row.getMaxRowSpan(columns)
return acc + row.getMaxCellHeight(columns)
}
rowSpan--
return acc
}, 0)
}

allRows() {
Expand Down Expand Up @@ -193,6 +203,13 @@ export class Row {
)
}

getMaxRowSpan(columns: Column[]) {
return columns.reduce(
(acc, column) => Math.max(acc, this.cells[column.index]?.rowSpan || 0),
0,
)
}

hasRowSpan(columns: Column[]) {
return (
columns.filter((column: Column) => {
Expand Down