Skip to content

Properly handle when all packages are up to date#70

Merged
simion merged 1 commit intosimion:masterfrom
danifr:handle_uptodate
Apr 1, 2026
Merged

Properly handle when all packages are up to date#70
simion merged 1 commit intosimion:masterfrom
danifr:handle_uptodate

Conversation

@danifr
Copy link
Copy Markdown
Contributor

@danifr danifr commented Mar 31, 2026

No description provided.

@simion
Copy link
Copy Markdown
Owner

simion commented Apr 1, 2026

AI review - Claude

🟢 Good (2)

  • Correct replacement of KeyboardInterrupt with normal control flowpip_upgrader/packages_interactive_selector.py (line 37)
    Using raise KeyboardInterrupt() to signal 'nothing to do' was a misuse of the exception — it's meant for user-initiated interrupts, not normal program flow. Returning an empty list and letting the caller handle it is the right approach.
  • Guard in cli.py prevents downstream errors on empty selectionpip_upgrader/cli.py (line 76)
    The if not selected_packages: return guard cleanly prevents PackagesUpgrader from being called with an empty list and avoids a potentially confusing empty 'Updated versions' message.

Bottom line: Clean, correct fix. No issues found — approve as-is.

Automated review by reviewd in 43s. Findings are AI-generated and may not be accurate.
Replies to this comment are not monitored.

@simion simion merged commit 9faa398 into simion:master Apr 1, 2026
6 checks passed
@simion
Copy link
Copy Markdown
Owner

simion commented Apr 1, 2026

thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants