Skip to content

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Jan 15, 2026

This issue happens when a user began as a Username-Password user that was later linked to a Paratext identity. When a user joins a project, if the user happens to have an alternate username on the user doc different than in Auth0, then a duplicate paratext user entry will be added to the ParatextUsers collection on the project. Some projects on QA, and on 1 project on live experienced this. The only issue this poses is that multiple users may appear in the users list.
This change ensures that we use the paratext username as the key to determine if a new entry should be inserted into the ParatextUsers collection on a project.

Cleaning up the QA and live projects will be a separate task.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.52%. Comparing base (2922a00) to head (936c4e1).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SIL.XForge.Scripture/Services/SFProjectService.cs 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3634      +/-   ##
==========================================
- Coverage   83.52%   83.52%   -0.01%     
==========================================
  Files         610      610              
  Lines       37504    37509       +5     
  Branches     6170     6171       +1     
==========================================
+ Hits        31327    31329       +2     
- Misses       5224     5226       +2     
- Partials      953      954       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-requested a review January 18, 2026 18:58
@pmachapman pmachapman self-assigned this Jan 18, 2026
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jan 18, 2026
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Jan 21, 2026
@Nateowami Nateowami force-pushed the fix/SF-3664-duplicate-paratext-users branch from 37503de to 936c4e1 Compare January 21, 2026 16:20
@Nateowami Nateowami enabled auto-merge (squash) January 21, 2026 16:20
@Nateowami Nateowami merged commit 34b607b into master Jan 21, 2026
21 checks passed
@Nateowami Nateowami deleted the fix/SF-3664-duplicate-paratext-users branch January 21, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants