Skip to content

LT-22156#311

Merged
AndyBlack merged 5 commits intomasterfrom
LT22156
Jun 19, 2025
Merged

LT-22156#311
AndyBlack merged 5 commits intomasterfrom
LT22156

Conversation

@AndyBlack
Copy link
Collaborator

@AndyBlack AndyBlack commented Jun 18, 2025

FLEx Ad hoc rules involving a clitic do not block in Hermit Crab.
There are two entries for these: one as a stem and one as an affix.
Any co-occurrence rules for these involve two items. The current code does not find a failure and does not report the failing rule.
The code fixes this for both morpheme and allomorph co-occurrence rules and includes new test cases for them.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (5e916a5) to head (d3d9d11).

Files with missing lines Patch % Lines
src/SIL.Machine.Morphology.HermitCrab/Allomorph.cs 26.66% 18 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   70.76%   70.83%   +0.06%     
==========================================
  Files         390      390              
  Lines       32723    32729       +6     
  Branches     4605     4609       +4     
==========================================
+ Hits        23155    23182      +27     
+ Misses       8510     8483      -27     
- Partials     1058     1064       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AndyBlack)


src/SIL.Machine.Morphology.HermitCrab/Allomorph.cs line 162 at r1 (raw file):

            if (AllomorphCoOccurrenceRules.Count > 0)
            {
                foreach (var rule in AllomorphCoOccurrenceRules)

Please make the type explicit, since it isn't explicit elsewhere in the line.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

@AndyBlack AndyBlack merged commit 90dcee6 into master Jun 19, 2025
4 checks passed
@AndyBlack AndyBlack deleted the LT22156 branch June 19, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants