Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 70.76% 70.83% +0.06%
==========================================
Files 390 390
Lines 32723 32729 +6
Branches 4605 4609 +4
==========================================
+ Hits 23155 23182 +27
+ Misses 8510 8483 -27
- Partials 1058 1064 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AndyBlack)
src/SIL.Machine.Morphology.HermitCrab/Allomorph.cs line 162 at r1 (raw file):
if (AllomorphCoOccurrenceRules.Count > 0) { foreach (var rule in AllomorphCoOccurrenceRules)
Please make the type explicit, since it isn't explicit elsewhere in the line.
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
FLEx Ad hoc rules involving a clitic do not block in Hermit Crab.
There are two entries for these: one as a stem and one as an affix.
Any co-occurrence rules for these involve two items. The current code does not find a failure and does not report the failing rule.
The code fixes this for both morpheme and allomorph co-occurrence rules and includes new test cases for them.
This change is