Skip to content

Hotfix: remove attention implementation#154

Merged
johnml1135 merged 2 commits intomainfrom
hotfix_remove_sdpa
Feb 3, 2025
Merged

Hotfix: remove attention implementation#154
johnml1135 merged 2 commits intomainfrom
hotfix_remove_sdpa

Conversation

@johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jan 31, 2025

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit January 31, 2025 17:31
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


machine/jobs/settings.yaml line 30 at r1 (raw file):

      add_unk_src_tokens: true
      add_unk_trg_tokens: true
    attn_implementation: sdpa

You should set it to eager, so that the behavior is explicit.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (de29377) to head (f9523b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files         275      275           
  Lines       16235    16235           
=======================================
  Hits        14337    14337           
  Misses       1898     1898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


machine/jobs/settings.yaml line 30 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should set it to eager, so that the behavior is explicit.

Also, the default in Huggingface is sdpa.

@johnml1135
Copy link
Collaborator Author

machine/jobs/settings.yaml line 30 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Also, the default in Huggingface is sdpa.

Done - and added comment.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 50cb1de into main Feb 3, 2025
14 checks passed
@johnml1135 johnml1135 deleted the hotfix_remove_sdpa branch February 3, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants