Hotfix: remove attention implementation#154
Conversation
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
machine/jobs/settings.yaml line 30 at r1 (raw file):
add_unk_src_tokens: true add_unk_trg_tokens: true attn_implementation: sdpa
You should set it to eager, so that the behavior is explicit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 275 275
Lines 16235 16235
=======================================
Hits 14337 14337
Misses 1898 1898 ☔ View full report in Codecov by Sentry. |
ddaspit
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
machine/jobs/settings.yaml line 30 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You should set it to
eager, so that the behavior is explicit.
Also, the default in Huggingface is sdpa.
|
Previously, ddaspit (Damien Daspit) wrote…
Done - and added comment. |
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
This change is