feat(installation-media): replace modal with wizard by default#2246
Merged
talos-bot merged 2 commits intosiderolabs:mainfrom Feb 9, 2026
Merged
feat(installation-media): replace modal with wizard by default#2246talos-bot merged 2 commits intosiderolabs:mainfrom
talos-bot merged 2 commits intosiderolabs:mainfrom
Conversation
Slessi
commented
Feb 2, 2026
Slessi
force-pushed
the
e2e-test-im-and-enable
branch
from
7f37360 to
cb4708b
Compare
Slessi
force-pushed
the
e2e-test-im-and-enable
branch
from
cb4708b to
c26514e
Compare
Slessi
force-pushed
the
e2e-test-im-and-enable
branch
from
c26514e to
f5595cc
Compare
Replace the Installation Media modal with the wizard by default. Signed-off-by: Edward Sammut Alessi <[email protected]>
Slessi
force-pushed
the
e2e-test-im-and-enable
branch
from
f5595cc to
3a676ae
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy “Download Installation Media” modal/feature-flag path and makes the Installation Media wizard the default entry point, updating navigation and E2E coverage accordingly.
Changes:
- Removes the
downloadInstallationMediamodal (component + story) and the localStorage feature flag (useInstallationMediaEnabled). - Updates UI entry points (Home, Machines help text, Sidebar, Join Tokens actions) to navigate to the
InstallationMediawizard route. - Adds/updates E2E coverage to exercise the wizard flow, and improves copy-button accessibility labels in the wizard confirmation step.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/omni/Settings/JoinTokens.vue | Removes “Download Installation Media” action from join token actions menu. |
| frontend/src/views/omni/Modals/DownloadInstallationMedia.vue | Deletes legacy modal implementation. |
| frontend/src/views/omni/Modals/DownloadInstallationMedia.stories.ts | Deletes Storybook story for the removed modal. |
| frontend/src/views/omni/Machines/Machines.vue | Changes inline navigation to route directly to InstallationMedia instead of opening a modal. |
| frontend/src/views/omni/InstallationMedia/Steps/Confirmation.vue | Adds explicit aria-labels for copy actions (CopyButton/CodeBlock). |
| frontend/src/views/omni/Home/HomeGeneralInformation.vue | Removes feature-flag gating; always routes to InstallationMedia. |
| frontend/src/methods/features.ts | Removes localStorage-backed useInstallationMediaEnabled feature flag helper. |
| frontend/src/components/common/CopyButton/CopyButton.vue | Extends prop typing to allow button HTML attributes (for a11y attrs like aria-label). |
| frontend/src/components/common/CodeBlock/CodeBlock.vue | Adds buttonAttrs prop to pass CopyButton attributes through. |
| frontend/src/components/common/Checkbox/TCheckbox.vue | Refactors checkbox to use reka-ui Checkbox components. |
| frontend/src/components/TModal.vue | Removes downloadInstallationMedia modal registration. |
| frontend/src/components/SideBar/TSideBar.vue | Always shows “Installation Media” sidebar entry (no feature flag). |
| frontend/e2e/talemu/installation_media.spec.ts | Adds new Playwright E2E test covering the wizard end-to-end. |
| frontend/e2e/talemu/home.spec.ts | Removes the old modal-based installation media download test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Write an E2E test for the installation media wizard to create, download, and delete an image. Validates information on the confirmation page as well. Signed-off-by: Edward Sammut Alessi <[email protected]>
Slessi
force-pushed
the
e2e-test-im-and-enable
branch
from
3a676ae to
9bca00a
Compare
Unix4ever
approved these changes
Feb 9, 2026
Member
|
💯 |
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2009
E2E test in action:
video.webm