Add explicit Start / Stop Service control#68
Open
RafhaanShah wants to merge 1 commit intoshrimqy:masterfrom
Open
Add explicit Start / Stop Service control#68RafhaanShah wants to merge 1 commit intoshrimqy:masterfrom
RafhaanShah wants to merge 1 commit intoshrimqy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's no way to fully exit the app / service, as the service starts on boot and is separate from the app UI
This PR adds support for starting and stopping the service via intents from 3rd party apps (e.g. Tasker)
Additionally adds a settings menu option to fully quit the app and service as well, addressing #61
If the service is stopped, it's guaranteed to start when the app launches now, as
NetworkManagerImplwill callNetworkService.start()Let me know if this looks good or if we should change something
Tested
START_SERVICEandSTOP_SERVICEvia Tasker +adb: