Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1889 entry 3.
Basically, Neoforge implemented Slots (SlotItemHandler) have a more strict mayPickup & mayPlace judgement.
When judging mayPickup, the slot would trigger a virtual takeItem operation, and rely on whether the return value (ideally the ItemStack to take) is an empty stack to judge. Hence when the slot is empty initially, it would be marked as not able to be picked up.
Similar issue occurred in mayPlace. When checking modifiability, the slot would try judging whether it's able to place the same item in the slot into it. But for an empty slot, the input ItemStack would be EMPTY, which is also blocked by Neoforge's judgement.
As a result, both ways will get wrong interactivity for an empty slot of SlotItemHandler. So we can do an extra judgement to see whether the slot is empty. Additionally, before actually placing items, a canPlace check is applyed, so we don't need to worry a wrong item transfer.