Skip to content

fix: calculate header size for offeset column#255

Open
Its-Just-Nans wants to merge 4 commits intosharkdp:masterfrom
Its-Just-Nans:change-for-large-file
Open

fix: calculate header size for offeset column#255
Its-Just-Nans wants to merge 4 commits intosharkdp:masterfrom
Its-Just-Nans:change-for-large-file

Conversation

@Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Feb 6, 2026

The size of the offset column is hardcoded

This break the output with large files (eg 4 Go)

cargo run -- --skip 4928310100 --length 20 larg_file.ext

BEFORE

┌────────┬─────────────────────────┬─────────────────────────┬────────┬────────┐
│0125c00b54│ 00 00 00 00 00 00 00 00 ┊ 00 00 00 00 00 a0 04 c0 │⋄⋄⋄⋄⋄⋄⋄⋄┊⋄⋄⋄⋄⋄ו×│
│0125c00b64│ 25 01 00 00             ┊                         │%•⋄⋄    ┊        │
└────────┴─────────────────────────┴─────────────────────────┴────────┴────────┘

AFTER

┌──────────┬─────────────────────────┬─────────────────────────┬────────┬────────┐
│0125c00b54│ 00 00 00 00 00 00 00 00 ┊ 00 00 00 00 00 a0 04 c0 │⋄⋄⋄⋄⋄⋄⋄⋄┊⋄⋄⋄⋄⋄ו×│
│0125c00b64│ 25 01 00 00             ┊                         │%•⋄⋄    ┊        │
└──────────┴─────────────────────────┴─────────────────────────┴────────┴────────┘

@Its-Just-Nans
Copy link
Contributor Author

The CI macos-13 is not usable anymore

fixed in #256

@sharkdp sharkdp closed this Feb 14, 2026
@sharkdp sharkdp reopened this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants