-
Notifications
You must be signed in to change notification settings - Fork 375
Enable Shakapacker early hints #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin808
wants to merge
26
commits into
master
Choose a base branch
from
justin808/shakapacker-early-hints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4e2e723
Add Thruster HTTP/2 proxy and Shakapacker early hints support
justin808 d64e758
Add Chrome DevTools Protocol scripts for verifying early hints
justin808 74cfc83
Fix Docker build by adding SECRET_KEY_BASE to react_on_rails:locale task
justin808 aed736d
Update react_on_rails to 16.2.0.beta.11
justin808 4698881
Update react-on-rails npm package to 16.2.0-beta.11
justin808 61c9469
Fix Rails 8.1+ deployment by adding SECRET_KEY_BASE to release script
justin808 014a974
Add SECRET_KEY_BASE to Control Plane GVC template
justin808 5fadd89
Enable Early Hints debug mode to verify if Rails sends HTTP 103
justin808 fe5bfc6
Update react_on_rails to 16.2.0.beta.12
justin808 54a7956
Update react_on_rails to use master branch from GitHub
justin808 e29a702
Improve development setup and webpack configuration
justin808 3f12f78
Update react_on_rails to use master branch from GitHub
justin808 63ce41f
Update react_on_rails and fix headless Chrome for tests
justin808 5730ac5
Update react_on_rails and fix headless Chrome for tests
justin808 f28ff59
Fix RuboCop line length violation in react_on_rails.rb
justin808 3c4dcd9
Improve Early Hints tooling and documentation
justin808 447cc56
Replace hardcoded PR review app URLs with placeholder
justin808 1995bca
lock files
justin808 0f66fce
Fix shakapacker gem/npm version mismatch
justin808 69fb64c
Add PropTypes to Footer icon components
justin808 1474111
Move Rails environment require before precompile tasks
justin808 8a93eef
Simplify build orchestration for rescript and locale generation
justin808 b25dca9
Add .context directory to .gitignore
justin808 32ea00f
Clean up configuration and remove duplicate code
justin808 22c9c04
Update react_on_rails to 16.2.0.rc1 and shakapacker to 9.5.0
justin808 154aa64
Address CodeRabbit review feedback
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| fail-fast: false | ||
| matrix: | ||
| node: [22.x] | ||
| ruby: [3.4.3] | ||
| ruby: [3.4.6] | ||
|
|
||
| env: | ||
| RAILS_ENV: test | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| fail-fast: false | ||
| matrix: | ||
| node: [22.x] | ||
| ruby: [3.4.3] | ||
| ruby: [3.4.6] | ||
|
|
||
| env: | ||
| RAILS_ENV: test | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| fail-fast: false | ||
| matrix: | ||
| node: [22.x] | ||
| ruby: [3.4.3] | ||
| ruby: [3.4.6] | ||
|
|
||
| services: | ||
| postgres: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.4.3 | ||
| 3.4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,10 @@ | |
| source "https://rubygems.org" | ||
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | ||
|
|
||
| ruby "3.4.3" | ||
| ruby "3.4.6" | ||
|
|
||
| gem "react_on_rails", "16.2.0.beta.20" | ||
| gem "shakapacker", "9.3.4.beta.0" | ||
| gem "react_on_rails", "16.2.0.rc1" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update to final version 16.2.1. |
||
| gem "shakapacker", "9.5.0" | ||
|
|
||
| # Bundle edge Rails instead: gem "rails", github: "rails/rails" | ||
| gem "listen" | ||
|
|
@@ -15,6 +15,7 @@ gem "rails", "~> 8.0" | |
| gem "pg" | ||
|
|
||
| gem "puma" | ||
| gem "thruster", "~> 0.1" | ||
|
|
||
| # Use SCSS for stylesheets | ||
| gem "sass-rails" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines should not be ignored if we are going to be committing these to the project.