Change timeouts to double for blocking list commands#632
Open
ibensw wants to merge 1 commit intosewenew:masterfrom
Open
Change timeouts to double for blocking list commands#632ibensw wants to merge 1 commit intosewenew:masterfrom
ibensw wants to merge 1 commit intosewenew:masterfrom
Conversation
Owner
|
Thanks for the contribution! However, this PR has 2 problems:
Looks like that we need to add an overloads instead of changing the type of timeout parameter from Regards |
Author
|
Thank you for your feedback. |
Owner
|
My bad! Looks like my building env is problematic, and it failed to build the test code. I cleaned the building env, and rebuild the code, it can build successfully, although the test fails with redis 4.0. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since redis 6.0.0, blocking list commands accept doubles as timeouts instead of integers.
This pull request updates the following parameters for the commands
blpop,brpop,brpoplpushandblmove:long long timeouttodouble timeoutstd::chrono::secondstostd::chrono::duration<double>