Various fixes for CRUD, Doorstop v3.1, dark mode, and smaller screens (plus some features I wanted)#17
Various fixes for CRUD, Doorstop v3.1, dark mode, and smaller screens (plus some features I wanted)#17ETSells wants to merge 3 commits intosevendays:masterfrom
Conversation
(Disclosure: significant AI-generated content) Various improvements and fixes for the following: - Updated API calls to Doorstop v3.1 - Removed minimum size for the table as it wouldn't fit properly on my laptop screen - Various dark mode fixes: - Changed the method used to "grey out" non-normative requirements - Changed the drop downs for booleans so that the text no longer overlaps the dropdown - The CRUD features I expected only seemed to have U and D. Re-implemented creation and deletion. Ensure the view updates correctly. - Window opens at an assumed default size (this was for my own convenience since the window was always way too small, but it might be too large for some screens which can be a headache. Suggestions welcome on how to handle this) - Added a feature to copy UIDs on double click (I have a tracing script that makes this feature very useful)
|
Oh wow. Let me review this
Il mer 4 feb 2026, 22:24 etsells ***@***.***> ha scritto:
… Slop.
*Various improvements and fixes for the following:*
- Updated API calls to Doorstop v3.1
- Removed minimum size for the table as it wouldn't fit properly on my
laptop screen
- Various dark mode fixes:
- Changed the method used to "grey out" non-normative requirements
- Changed the drop downs for booleans so that the text no longer
overlaps the dropdown
- The CRUD features I expected only seemed to have U and D.
Re-implemented creation and deletion. Ensure the view updates correctly.
- Window opens at an assumed default size (this was for my own
convenience since the window was always way too small, but it might be too
large for some screens which can be a headache. Suggestions welcome on how
to handle this)
- Added a feature to copy UIDs on double click (I have a tracing
script that makes this feature very useful)
- Added an feature to indent requirement tree by level if an option is
selected
Disclosure: significant AI-generated content -- The contents of this PR
are primarily AI generated based on problems I encountered with the most
recent version of this software. I've reviewed and tested everything that
was generated and I intend to use this version for my own projects, but I
also figured the disclosure was necessary due to the amount that's included
that is not my own work.
Untested Environments: light-mode and larger screens.
------------------------------
You can view, comment on, or merge this pull request online at:
#17
Commit Summary
- 8469f85
<8469f85>
Slop.
- a20a082
<a20a082>
feat: add indentation for requirement tree
File Changes
(1 file <https://github.com/sevendays/doorhole/pull/17/files>)
- *M* doorhole.py
<https://github.com/sevendays/doorhole/pull/17/files#diff-84fa4e05ec7d4e174a390161bf5782d83991c77b64aba6ae9ea10ed68a2aa879>
(250)
Patch Links:
- https://github.com/sevendays/doorhole/pull/17.patch
- https://github.com/sevendays/doorhole/pull/17.diff
—
Reply to this email directly, view it on GitHub
<#17>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJU2MS52U6XOD45DCZQ5D4KJPPBAVCNFSM6AAAAACUALCLC2VHI2DSMVQWIX3LMV43ASLTON2WKOZTHA4TQNBXHAZTAOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I'm using the Doorstop reqs folder to have a set of requirements. I'm seeing a small issue with the indentation: the level attribute can be specified as both 1 and 1.0, but when it is actually specified as 1.0 then the applied indentation is the same as 1.1 
The behaviour is correct with level 1, but then it is "normative", e.g. something you need to implement, rather than a mere title/subtitle. 
|
|
I very much appreciate the possibility of adding requirements and the fact that it adds the requirement right below the selected one, with the next 'level'. The issue is that a new custom attribute is inserted, 'doc', that apparently has a json dump of the requirement itself. 
|
|
@sevendays Thanks for taking a look!
I will address your comments and make the requested fixes as soon as I have a moment, and ping you again once it's ready for re-review. Just to give you a heads up, I'm a student and in the middle of my midterm season so it may be another week or two before I can do this. |
|
Hi @ETSells,
Thanks to you for contributing! I changed job some time ago, so I'm not
really doing requirements management anymore.
Regarding the "doc" attribute and how to reproduce the issue:
- I copied and pasted the "/reqs" folder from the Doorstop git repository
to the Doorhole git repository
- I installed everything needed (including Doorstop itself, pip install
doorstop)
- I launched doorhole from CLI inside the Doorhole repo root (python
doorhole.py)
The Doorstop version is 3.1. I'm on a Fedora linux 43 laptop right now.
Il giorno gio 26 feb 2026 alle ore 21:27 etsells ***@***.***>
ha scritto:
… *ETSells* left a comment (sevendays/doorhole#17)
<#17 (comment)>
@sevendays <https://github.com/sevendays> Thanks for taking a look!
1. I can fix the indentation for sure. I took a fairly naive approach
here and can cover this edge case without much difficulty to ensure that
x.0 is indented the same amount as x. Are you saying that whether a
requirement is marked as normative influences how level attribute is
written? I was not aware of this and did not account for it.
2. I have no idea how the "doc" attribute was inserted. Can you
provide steps to reproduce this behavior? Also, can you confirm which
version of Doorstop you have installed? My testing was limited to v3.x, so
if you're on 2.x there may be changes I didn't account for.
I will address your comments and make the requested fixes as soon as I
have a moment, and ping you again once it's ready for re-review. Just to
give you a heads up, I'm a student and in the middle of my midterm season
so it may be another week or two before I can do this.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJU2JNOGLECXIERO3HQCT4N5JKNAVCNFSM6AAAAACUALCLC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNRZGA2DMNBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@sevendays Finally had a second to investigate and make the requested fixes. IndentationFix applied in commit 0a3244f. 
Insertion of new attributeI was able to reproduce the problematic behavior. I didn't get this behavior on my own test set: 
But it's definitely present in the doorstop SRD. 
Upon investigation, it seems that the "doc" attribute doesn't have a json dump of the requirement, but rather includes a bunch of attributes that would appear to come from the document itself. 
These are defined in the .doorstop.yml for the document as a default attribute. 
It seems to me like this is actually intentional behavior to include the document's default attribute in every new requirement. Indeed, when you create a new requirement using the doorstop CLI, the attribute is also present there. 
Because of this, I believe the issue here is in the doorstop test set and not with my changes, so I will not be taking action to resolve that behavior. |
2 participants
Slop.
Various improvements and fixes for the following:
Disclosure: significant AI-generated content -- The contents of this PR are primarily AI generated based on problems I encountered with the most recent version of this software. I've reviewed and tested everything that was generated and I intend to use this version for my own projects, but I also figured the disclosure was necessary due to the amount that's included that is not my own work.
Untested Environments: light-mode and larger screens.