Add segment_prop_dir and segment_properties arguments for the precomputed format#638
Draft
chourroutm wants to merge 9 commits intoseung-lab:masterfrom
Draft
Add segment_prop_dir and segment_properties arguments for the precomputed format#638chourroutm wants to merge 9 commits intoseung-lab:masterfrom
segment_prop_dir and segment_properties arguments for the precomputed format#638chourroutm wants to merge 9 commits intoseung-lab:masterfrom
Conversation
Contributor
|
Hi! This is great, thank you! Is the PR ready for review? I was looking it over and it didn't seem to be actually doing anything with the |
Contributor
Author
|
Hi! At the moment, it only adds the "segment_properties" field to the info file, to point to the subdir with the data. I'll have to write a CSV-to-segment_properties snippet anyway, which I can append to the PR. Should I withdraw the PR for now? Also, I cannot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new argument to handle the "segment_properties" sidecar subdirectory and its info file.
References:
This will solve #637.