Skip to content

Add segment_prop_dir and segment_properties arguments for the precomputed format#638

Draft
chourroutm wants to merge 9 commits intoseung-lab:masterfrom
chourroutm:master
Draft

Add segment_prop_dir and segment_properties arguments for the precomputed format#638
chourroutm wants to merge 9 commits intoseung-lab:masterfrom
chourroutm:master

Conversation

@chourroutm
Copy link
Contributor

@william-silversmith william-silversmith added the feature A new capability is born. label Sep 23, 2024
@william-silversmith
Copy link
Contributor

Hi! This is great, thank you! Is the PR ready for review? I was looking it over and it didn't seem to be actually doing anything with the segment_properties yet. Thanks again, this will be a great contribution!

@chourroutm
Copy link
Contributor Author

Hi! At the moment, it only adds the "segment_properties" field to the info file, to point to the subdir with the data. I'll have to write a CSV-to-segment_properties snippet anyway, which I can append to the PR. Should I withdraw the PR for now?

Also, I cannot git clone the files onto my Windows 11 workstation because of some filenames which contain ':'.

@chourroutm chourroutm marked this pull request as draft October 6, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new capability is born.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants