Enabling parsing first-letter pseudo element for servo#320
Open
minghuaw wants to merge 3 commits intoservo:mainfrom
Open
Enabling parsing first-letter pseudo element for servo#320minghuaw wants to merge 3 commits intoservo:mainfrom
first-letter pseudo element for servo#320minghuaw wants to merge 3 commits intoservo:mainfrom
Conversation
Collaborator
|
Please rebase this, you are including commits from other PRs. |
minghuaw
force-pushed
the
feat/first-letter
branch
from
d6494fb to
dc0726b
Compare
Contributor
Author
Thanks! Rebased |
minghuaw
force-pushed
the
feat/first-letter
branch
from
dc0726b to
69b55e9
Compare
Loirooriol
reviewed
Mar 7, 2026
Contributor
Author
|
@Loirooriol Addressed the comments in 65ed94c. Would you mind taking a look at the servo PR as well? It's much simplified after addressing Xiaocheng's comment |
Loirooriol
changed the title
first-letter psuedo element for servofirst-letter pseudo element for servo
Loirooriol
force-pushed
the
feat/first-letter
branch
from
6aa0d5d to
5a11443
Compare
minghuaw
force-pushed
the
feat/first-letter
branch
from
5a11443 to
643db54
Compare
Signed-off-by: Minghua Wu <[email protected]>
Signed-off-by: Minghua Wu <[email protected]>
Signed-off-by: Minghua Wu <[email protected]>
minghuaw
force-pushed
the
feat/first-letter
branch
from
643db54 to
80316b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables parsing
first-letterpseudo element for servo. An accompanying servo PR (servo/servo#43027) is open