Allow specifying a version for Minify

AGENTS.md

@@ -0,0 +1,30 @@
+# AGENTS.md
+
+## Scope
+This repository is a Symfony bundle. Follow Symfony best practices and keep changes consistent with the bundle’s existing architecture.
+
+## Engineering Expectations
+- Prefer dependency injection over service container access.
+- Keep public APIs stable and documented.
+- Follow PSR-4 autoloading: `src/` for production code, `tests/` for test code.
+- Keep configuration under `config/` and avoid hard-coding environment-specific values.
+- Use Symfony contracts and components already listed in `composer.json`.
+
+## Tests and Static Analysis
+Run these from the repo root:
+
+```sh
+composer install
+```
+
+```sh
+vendor/bin/phpunit -c phpunit.dist.xml
+```
+
+```sh
+vendor/bin/phpstan analyse -c phpstan.dist.neon
+```
+
+## Notes
+- PHPUnit uses `Sensiolabs\MinifyBundle\Tests\Fixtures\MinifyBundleTestKernel` via `phpunit.dist.xml`.
+- PHPStan level is configured in `phpstan.dist.neon` and excludes `src/SensiolabsMinifyBundle.php`.

README.md

@@ -208,6 +208,9 @@ sensiolabs_minify:
 
         # the local path where the downloaded binary is stored
         download_directory: '%kernel.project_dir%/var/minify'
+
+        # the Minify version to download (default: null for latest)
+        version: null
 ```
 
 You can customize this configuration to use a local binary:

config/services.php

@@ -27,6 +27,7 @@
         ->set('.sensiolabs_minify.minifier.minify_installer', MinifyInstaller::class)
             ->args([
                 abstract_arg('download_path'),
+                abstract_arg('download_version'),
                 service('http_client')->nullOnInvalid(),
             ])
 

src/MinifyInstaller.php

@@ -33,6 +33,7 @@ final class MinifyInstaller implements MinifierInstallerInterface
 
     public function __construct(
         private readonly string $installDirectory,
+        private readonly ?string $defaultVersion = null,
         ?HttpClientInterface $httpClient = null,
     ) {
         if (null === $httpClient && !class_exists(HttpClient::class)) {
@@ -48,6 +49,10 @@ public function install(string $version = self::VERSION_LATEST, bool $force = fa
             return;
         }
 
+        if (self::VERSION_LATEST === $version && null !== $this->defaultVersion && '' !== $this->defaultVersion) {
+            $version = $this->defaultVersion;
+        }
+
         $this->download($version);
     }
 

src/SensiolabsMinifyBundle.php

@@ -39,6 +39,7 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
         $container->services()
             ->get('.sensiolabs_minify.minifier.minify_installer')
                 ->arg(0, $config['minify']['download_directory'])
+                ->arg(1, $config['minify']['version'])
 
             ->get('.sensiolabs_minify.minifier.minify_factory')
                 ->arg(0, $config['minify']['local_binary'])
@@ -120,6 +121,10 @@ public function configure(DefinitionConfigurator $definition): void
                             ->info('Directory to store the downloaded binary')
                             ->defaultValue('%kernel.project_dir%/var/minify')
                         ->end()
+                        ->scalarNode('version')
+                            ->info('Minify version to download (null for latest)')
+                            ->defaultNull()
+                        ->end()
                     ->end()
                 ->end()
             ->end()

tests/MinifyInstallerTest.php

@@ -27,7 +27,7 @@ public function testExceptionIsThrownWhenBinaryCannotBeDownloaded(): void
     {
         $httpClient = $this->createMock(HttpClientInterface::class);
         $httpClient->method('request')->willReturn($this->createMockResponse(500));
-        $installer = new MinifyInstaller('/tmp/minify/'.rand(5, 999), $httpClient);
+        $installer = new MinifyInstaller('/tmp/minify/'.rand(5, 999), null, $httpClient);
 
         $this->expectException(InstallException::class);
         $installer->install();