Draft
Conversation
c51f18c to
8d98d1f
Compare
3a5bc25 to
906e079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pygnssutils Pull Request Template
Description
Add preliminary support for RINEX bulk data conversion.
NB: This ALPHA release is limited to the following functionality:
pyrinexconvCLI RINEX conversion utility - typepyrinexconv -hfor helpGNSSReaderand its underlying Python message parsers (i.e. NMEA0183, UBX, RTCM3, SBF, QGC, UNI).Further RINEX versions and conversion functionality will be added in future releases, as and when time permits.
CONTRIBUTORS WELCOME:
For each RINEX output category (OBS, NAV, MET), the mechanics of RINEX text output formatting is essentially complete (in accordance with protocol 3.05), driven by a series of Python data dictionaries
obsdata,navdataandmetdata. The outstanding work is to identify all the relevant GNSS data sources (UBX, RTCM, NMEA, etc.) and individual message attributes for each category and update the corresponding data dictionary accordingly. NOTE THAT the underlyingpyubx2UBX parser does not currently parse the individual NAV subframes carried by UBX RXM-SFRBX message types - the information is not part of the UBX protocol specification but is available from other public domain sources (e.g. GPS ICD at gps.gov); this work would need to be completed before UBX RXM-SFRBX messages can be utilised bypyrinexconvfor RINEX NAV data conversion.Testing
Please test all changes, however trivial, against the supplied pytest suite
tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.Checklist:
tests/test_*.pyunittest suite to maintain >= 99% code coverage.tests/test_*.pyunittest suite.