Skip to content

fix(group): allow 0n values in Group constructor #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vplasencia merged 1 commit into from
Jan 19, 2026
+6 −10
Merged

fix(group): allow 0n values in Group constructor #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/group/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ export class Group {
* @param members A list of identity commitments.
*/
constructor(members: BigNumber[] = []) {
for (const member of members) {
if (member === 0n || member === "0") {
throw new Error("Failed to add member: value cannot be 0")
}
}

this.leanIMT = new LeanIMT((a, b) => poseidon2([a, b]), members.map(BigInt))
}

Expand Down
10 changes: 6 additions & 4 deletions packages/group/tests/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ describe("Group", () => {
expect(group.size).toBe(3)
})

it("Should not create a group with a list of members if any value is 0", () => {
const fun = () => new Group([1n, 0n])

expect(fun).toThrow("Failed to add member: value cannot be 0")
it("Should reconstruct a group after removing a member", () => {
const group = new Group([1n, 2n, 3n])
group.removeMember(1)
const { members } = group
const newGroup = new Group(members)
expect(newGroup.members).toEqual([1n, 0n, 3n])
})
})

Expand Down