Open
Conversation
🦋 Changeset detectedLatest commit: 792d385 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…build-package-patch
samchungy
reviewed
Feb 10, 2026
Contributor
samchungy
left a comment
samchungy
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing, slowly catching up
src/cli/lint/internalLints/upgrade/patches/14.0.1/patchPackageBuilds.ts
Outdated
Show resolved
Hide resolved
src/cli/lint/internalLints/upgrade/patches/14.0.1/patchPackageBuilds.ts
Outdated
Show resolved
Hide resolved
|
|
||
| let foundMatch = false; | ||
|
|
||
| for (const packageJsonPath of likelyPackagePaths) { |
Contributor
There was a problem hiding this comment.
nit: shall we do this in parallel?
| let assetsData; | ||
|
|
||
| if (assetsArray) { | ||
| assetsData = JSON.parse(assetsArray?.text()) as unknown; |
Contributor
There was a problem hiding this comment.
Could we remove the assets data too?
Contributor
Author
There was a problem hiding this comment.
(As per, my troubles with this was a skill issue 🤦)
…Builds.ts Co-authored-by: Sam Chung <samc@seek.com.au>
…Builds.ts Co-authored-by: Sam Chung <samc@seek.com.au>
samchungy
approved these changes
Feb 14, 2026
… as the target `package.json`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1904