editor: Ensure interactive after toggling via menu#481
Merged
michaeltaranto merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 2f85e78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixhabib
approved these changes
Feb 25, 2026
Contributor
felixhabib
left a comment
felixhabib
left a comment
There was a problem hiding this comment.
any reason this needs to be a layout effect over a useEffect?
Contributor
Author
Yes, this ensures that no user interaction can happen in between "needing to update" the attribute and it "actually updating". Whereas updating in a plain effect gives you no timing guarantees |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the editor would remain
inertwhen hidden via the "Hide Code" button and then shown via the menu.