Skip to content

Kerberos improvements, bug fixes in LDAP#4709

Merged
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:bugfixes-win
Mar 31, 2025
Merged

Kerberos improvements, bug fixes in LDAP#4709
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:bugfixes-win

Conversation

@gpotter2
Copy link
Member

Various bug fixes:

  • parsing of more kerberos errors in fast mode
  • hide deprecation warnings on Python 3.13 (used internally in Python 3.13...)
  • minor additions to [MS-DRSR]
  • improvements to ticketer
  • enable missing padding in NDR64 (that I really suspected should be enabled eventually, but yeah it needed)

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (9e4dc1d) to head (f44ed74).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/msrpce/msdrsr.py 34.78% 15 Missing ⚠️
scapy/layers/kerberos.py 41.17% 10 Missing ⚠️
scapy/modules/ticketer.py 46.15% 7 Missing ⚠️
scapy/config.py 0.00% 3 Missing ⚠️
scapy/layers/msrpce/rpcclient.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4709      +/-   ##
==========================================
- Coverage   82.13%   82.10%   -0.03%     
==========================================
  Files         361      361              
  Lines       86846    86901      +55     
==========================================
+ Hits        71327    71351      +24     
- Misses      15519    15550      +31     
Files with missing lines Coverage Δ
scapy/layers/dcerpc.py 90.61% <100.00%> (+0.04%) ⬆️
scapy/layers/ldap.py 67.50% <100.00%> (-0.09%) ⬇️
scapy/layers/smbclient.py 73.96% <100.00%> (ø)
scapy/layers/msrpce/rpcclient.py 52.27% <0.00%> (ø)
scapy/config.py 80.64% <0.00%> (-0.25%) ⬇️
scapy/modules/ticketer.py 35.09% <46.15%> (-0.09%) ⬇️
scapy/layers/kerberos.py 60.75% <41.17%> (-0.17%) ⬇️
scapy/layers/msrpce/msdrsr.py 53.12% <34.78%> (-46.88%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit be3cfbd into secdev:master Mar 31, 2025
24 checks passed
@gpotter2 gpotter2 deleted the bugfixes-win branch March 31, 2025 07:28
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant