Throw an error if encryption is enabled but the algorithm isn't specified#28
Open
MichaelBurge wants to merge 1 commit intoscsitape:masterfrom
Open
Throw an error if encryption is enabled but the algorithm isn't specified#28MichaelBurge wants to merge 1 commit intoscsitape:masterfrom
MichaelBurge wants to merge 1 commit intoscsitape:masterfrom
Conversation
…fied. It defaults to 0, and my AES drive expects a 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I first tried to use this tool, I forgot to set the
-aparameter to specify the encryption algorithm. After comparingstrace -e ioctloutput with a SCSI command reference manual, I saw that thealgorithmIndexwasn't being set and specifying this parameter allowed the drive to accept it.This change causes this command:
to instead output:
if the
-e on,-e mixed, or-e rawreadoptions are set but no algorithm index is set.