Skip to content

accessibility: Make share & remix buttons more accessible #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosics-code wants to merge 10 commits into
base: release/UEPR-297-accessibility-improvements
Choose a base branch
from
Open

accessibility: Make share & remix buttons more accessible #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
affa366
fix(deps): update dependency scratch-paint to v4.1.54
renovate[bot] May 9, 2026
cb3d1ab
style(deps): update dependency eslint-config-scratch to v14.1.19
renovate[bot] May 9, 2026
0e1f4f1
Add dark green color variable to colors.css
rosics-code May 10, 2026
68ac83d
Merge branch 'scratchfoundation:develop' into patch-4
rosics-code May 10, 2026
2919004
Fix background color for remix-button
rosics-code May 10, 2026
f2491cb
Add dark red color variable to colors.css
rosics-code May 10, 2026
8e87392
Change share button background color to ui-red-dark
rosics-code May 10, 2026
67477cf
Change cursor style for share button states
rosics-code May 10, 2026
8859d71
Change share button cursor to pointer
rosics-code May 10, 2026
0905cee
Change share button cursor to default
rosics-code May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
216 changes: 117 additions & 99 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/scratch-gui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"scratch-audio": "2.0.268",
"scratch-blocks": "2.1.19",
"scratch-l10n": "6.1.75",
"scratch-paint": "4.1.52",
"scratch-paint": "4.1.54",
"scratch-render-fonts": "1.0.252",
"scratch-storage": "6.2.1",
"startaudiocontext": "1.2.1",
Expand Down Expand Up @@ -212,7 +212,7 @@
"cheerio": "1.2.0",
"cross-env": "7.0.3",
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"eslint-import-resolver-typescript": "4.4.4",
"eslint-plugin-import-x": "4.16.2",
"eslint-plugin-react": "7.37.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/scratch-gui/src/components/menu-bar/menu-bar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
}

.remix-button {
background-color: $pen-primary
background-color: $ui-green-dark;
}

.remix-button-icon {
Expand Down
5 changes: 3 additions & 2 deletions packages/scratch-gui/src/components/menu-bar/share-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
@import "../../css/colors.css";

.share-button {
background: $data-primary;
background: $ui-red-dark;
cursor: default;
}

.share-button-is-shared {
background: $ui-black-transparent;
cursor: default;
cursor: not-allowed;
}
2 changes: 2 additions & 0 deletions packages/scratch-gui/src/css/colors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ $ui-black-transparent-10: hsla(0, 0%, 0%, 0.10); /* 10% transparent version of b

$ui-green: hsla(163, 85%, 35%, 1); /* #0DA57A */
$ui-green-2: hsla(163, 85%, 40%, 1); /* #0FBD8C */
$ui-green-dark: hsla(144, 45%, 36%, 1); /* #328554 */

$ui-orange: hsla(37, 96%, 55%, 1); /* #FAA51D */
$ui-alert-orange: hsla(32, 100%, 94%, 1); /* #FFF0DF */
$ui-red-dark: hsl(20, 100%, 40%); /* #c40 */
$text-primary: hsla(225, 15%, 40%, 1); /* #575E75 */
$text-primary-transparent: hsla(225, 15%, 40%, 0.75);

Expand Down
2 changes: 1 addition & 1 deletion packages/scratch-media-lib-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"devDependencies": {
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"jest": "30.3.0",
"jest-junit": "16.0.0",
"prettier": "3.8.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/scratch-render/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"copy-webpack-plugin": "6.4.1",
"docdash": "0.4.0",
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"globals": "16.5.0",
"html-webpack-plugin": "5.6.7",
"playwright-chromium": "1.59.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/scratch-svg-renderer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"canvas": "3.2.3",
"copy-webpack-plugin": "6.4.1",
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"globals": "16.5.0",
"jsdom": "13.2.0",
"mkdirp": "2.1.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/scratch-vm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"copy-webpack-plugin": "6.4.1",
"docdash": "1.2.0",
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"expose-loader": "1.0.3",
"file-loader": "6.2.0",
"format-message-cli": "6.2.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/task-herder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"devDependencies": {
"@vitest/coverage-v8": "4.1.5",
"eslint": "9.39.4",
"eslint-config-scratch": "14.1.17",
"eslint-config-scratch": "14.1.19",
"prettier": "3.8.3",
"rimraf": "6.1.2",
"typescript": "5.9.3",
Expand Down
Loading