fix: allow SVG filter elements#300
Open
scratching-claws wants to merge 2 commits intoscratchfoundation:developfrom
Open
fix: allow SVG filter elements#300scratching-claws wants to merge 2 commits intoscratchfoundation:developfrom
scratching-claws wants to merge 2 commits intoscratchfoundation:developfrom
Conversation
Adds a rule to allow the SVG filter tag, when sanitizing SVGs, so that effects such as shadows and blur do not lead to SVGs which don't diplay on the project stage
|
Will this also allow things like I've looked at DOMPurify's readme page and it says there is a toggle for SVG filters |
Author
That is a very good point, and thank you for raising it. I have changed the pull request so that is now uses the SVG filters profile, instead of only allowing the additional tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rule to allow the SVG filter tag, when sanitizing SVGs, so that effects such as shadows and blur do not lead to SVGs which don't diplay on the project stage
Resolves
Fixes this issue: #269
Proposed Changes
Adds a rule to allow the SVG filter tag
Reason for Changes
Stops the SVG sanitizer from removing filter tags from SVGs, so that SVGs with shadows/blur display correctly on the stage