Conversation
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 95.62% 96.13% +0.50%
==========================================
Files 10 10
Lines 183 207 +24
Branches 48 60 +12
==========================================
+ Hits 175 199 +24
Misses 3 3
Partials 5 5
🚀 New features to boost your workflow:
|
Collaborator
Author
|
@TonyCongqianWang you might want to have a look into this |
|
I'll try to do it tomorrow! |
TonyCongqianWang
approved these changes
Jan 31, 2025
TonyCongqianWang
left a comment
There was a problem hiding this comment.
Looks good to me. Not having spans should not be a big drawback since copying variables is not going to be very expensive. Using std::vector should allow enough flexibility for most use cases
erogelio18
reviewed
Aug 21, 2025
erogelio18
reviewed
Aug 25, 2025
f66d8af to
5861442
Compare
Collaborator
Author
|
@erogelio18 ready for next review round |
Collaborator
Author
|
Mac CI fails because Conan center is currently offline |
erogelio18
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new c'tors to LinExpr to speed-up the creation of expressions with multiple variables.
Fixes #32
This is an alternative implementation of #34