Fixed typo in rtc_config_example.json

[shommey]

"urls": "turns::5349" changed to
"urls": "turn::5349"

This little oversight costed me a few hours of my life I'll never get back. :)

[schlagmichdoch]

turns::5349 is the correct way if you want TURN over TLS. (See https://github.com/schlagmichdoch/PairDrop/blob/master/docs/host-your-own.md#coturn-and-pairdrop-via-docker-compose)

If you want to implement TURN without additional TLS encryption (which is fine) you should use turn::3478 as this is the standard port for STUN and TURN without TLS or change the port to whatever you have specified in your turnserver.conf. (See

PairDrop/turnserver_example.conf

Line 12 in ce3d569

# Main listening port for STUN and TURN

)

So I can't merge this PR as it is.

Maybe the turn::3478 config should be included additionally to the two existing or we should have different config files for TURN with and w/o TLS. What do you think?

Where did you take a look for the configuration? I guess this could also be solved by a simple reference of the different versions (stun:, turn:, turns:) in the docs here: https://github.com/schlagmichdoch/PairDrop/blob/master/docs/host-your-own.md#specify-stunturn-servers

[shommey]

I see, sorry for the mix up then.
I think the docs should mention that "s" in the "turns" stands for turn tls.
It could be great if turn: and turns: difference could be pointed out in .json itself.

[schlagmichdoch]

Sorry for the late reply. Trying to catch up with the issue built-up.

It could be great if turn: and turns: difference could be pointed out in .json itself.

How about we duplicate the turn server part and describe it in the "domain name"?

{
  "sdpSemantics": "unified-plan",
  "iceServers": [
    {
      "urls": "stun:<DOMAIN-OF-STUN-SERVER>:3478"
    },
    {
      "urls": "turn:<DOMAIN-OF-TURN-SERVER>:5349",
      "username": "username",
      "credential": "password"
    },
    {
      "urls": "turns:<DOMAIN-OF-TURN-OVER-TLS-SERVER>:5349",
      "username": "username",
      "credential": "password"
    }
  ]
}

[schlagmichdoch]

turn over tls description. See comment in conversation