Implement a fallback to send texts bigger than the max message size#280
Open
schlagmichdoch wants to merge 2 commits intosw_digesterfrom
Open
Implement a fallback to send texts bigger than the max message size#280schlagmichdoch wants to merge 2 commits intosw_digesterfrom
schlagmichdoch wants to merge 2 commits intosw_digesterfrom
Conversation
… to sent them in chunks via the send files API
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, sending messages between Firefox and Chrome that exceed ~180 kB throw an error. This is because the maximum size of WebRTC messages for Chrome is 256 kB and base64 encoding the message bloats it.
This PR implements a fallback for bigger text messages. These are then sent via the File Sending API including a Message Transfer Request.