Skip to content

Upload mags+attachments to existing dataset, adapt to wk api 14#1450

Draft
fm3 wants to merge 4 commits intomasterfrom
upload-mags-attachments
Draft

Upload mags+attachments to existing dataset, adapt to wk api 14#1450
fm3 wants to merge 4 commits intomasterfrom
upload-mags-attachments

Conversation

@fm3
Copy link
Copy Markdown
Member

@fm3 fm3 commented Apr 8, 2026

Description:

Issues:

  • fixes #...

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests
  • Considered adding this to the Examples

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dataset upload process to align with API version 14, including refactoring upload models and updating API routes. It introduces ApiDatasetUploadInfo and ApiResumableUploadInfo while simplifying the parameters for finishing and reserving uploads. A review comment recommends using datastore_api_client.url_prefix for the Resumable upload URL to maintain consistency with the versioned API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant