Fix beacons not sent when beacon_refresh called #68549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrx312
reviewed
Dec 17, 2025
Contributor
Author
|
I think i just need to re-run the tests here, not sure how to do that @twangboy ? |
twangboy
approved these changes
Jan 15, 2026
Contributor
|
Changing labels will restart the tests. We want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
Fixes: #68548
Previous Behavior
The interval_map would get re-set to 0 whenever we called beacons_refresh. If beacons_refresh is continually getting called for example when running a state run then the beacons would never get sent.
New Behavior
interval_map is preserved if set and the beacon still gets sent when running a state run (or any other situation that refreshes beacon)